Skip to content

Commit

Permalink
Revert "kola/tests: Skip tests that change the verity hash when SB is…
Browse files Browse the repository at this point in the history
… enabled"

This reverts commit b583d18. I
misunderstood what these tests do. Booting is supposed to fail after
changing the verity hash, but then it is supposed to successfully fall
back to the other partition. The tests were failing due one of Red Hat's
GRUB patches. We have now fixed this.

Signed-off-by: James Le Cuirot <[email protected]>
  • Loading branch information
chewi committed Oct 24, 2024
1 parent 1b0fd73 commit 386d721
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions kola/tests/misc/update.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (

"golang.org/x/net/context"

"github.com/flatcar/mantle/kola"
"github.com/flatcar/mantle/kola/cluster"
"github.com/flatcar/mantle/kola/register"
"github.com/flatcar/mantle/kola/tests/util"
Expand Down Expand Up @@ -59,9 +58,6 @@ func init() {
Distros: []string{"cl"},
// This test is normally not related to the cloud environment
Platforms: []string{"qemu", "qemu-unpriv"},
// Changing the verity hash breaks Secure Boot verification, causing
// GRUB to error and then just sit at the menu forever.
SkipFunc: kola.SkipSecureboot,
})
register.Register(&register.Test{
Run: RecoverBadUsr,
Expand All @@ -72,9 +68,6 @@ func init() {
Distros: []string{"cl"},
// This test is normally not related to the cloud environment
Platforms: []string{"qemu", "qemu-unpriv"},
// Changing the verity hash breaks Secure Boot verification, causing
// GRUB to error and then just sit at the menu forever.
SkipFunc: kola.SkipSecureboot,
})
}

Expand Down

0 comments on commit 386d721

Please sign in to comment.