Apply suggestions from code review

Co-authored-by: Kai Lüke <[email protected]>

cmd/ore/brightbox/gc.go

@@ -13,7 +13,7 @@ var (
 	cmdGC = &cobra.Command{
 		Use:   "gc",
 		Short: "GC resources in Brightbox",
-		Long:  `Delete instances created over the given duration ago`,
+		Long:  `Delete instances and images created over the given duration ago`,
 		RunE:  runGC,
 	}
 

kola/tests/kubeadm/kubeadm.go

@@ -243,7 +243,7 @@ func init() {
 						// Let's skip this test for < 3034 on ESX
 						// * For Cilium Calico/CNI on Brightbox:
 						// unprocessable_entity: User data is too long (maximum is 16384 characters)
-						// Should be reenable once we switch to Butane provisioning.
+						// Should be reenabled once we switch to Butane provisioning because of internal compression.
 						return (version.LessThan(semver.Version{Major: 3034}) && platform == "esx") ||
 							(platform == "brightbox" && (cni == "cilium" || cni == "calico"))
 					},

platform/api/brightbox/api.go

@@ -218,7 +218,7 @@ func (a *API) UploadImage(name, URL string) (string, error) {
 	}
 
 	// It usually takes around 20 seconds to extract the image.
-	if err := util.WaitUntilReady(1*time.Minute, 5*time.Second, func() (bool, error) {
+	if err := util.WaitUntilReady(2*time.Minute, 5*time.Second, func() (bool, error) {
 		image, err := a.client.Image(context.TODO(), img.ID)
 		if err != nil {
 			return false, fmt.Errorf("getting image status: %w", err)

platform/machine/brightbox/flight.go

@@ -42,7 +42,7 @@ func NewFlight(opts *brightbox.Options) (platform.Flight, error) {
 		BaseFlight: base,
 		api:        api,
 		// Current CloudIPs limit is 5.
-		cloudIPs: make(chan string, 5),
+		cloudIPs: make(chan string, 999),
 	}
 
 	return bf, nil