Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/godbus/dbus and github.com/coreos/go-systemd #8

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

invidian
Copy link
Member

@invidian invidian commented Nov 17, 2020

This would be nice to have to be able to make https://github.com/kinvolk/flatcar-linux-update-operator depend on locksmith code as right now it include files which are copy-pasted from this repository and I plan to remove them.

Signed-off-by: Mateusz Gozdek [email protected]

@invidian invidian changed the title Update github.com/godbus/dbus to latest compatible version Update github.com/godbus/dbus and github.com/coreos/go-systemd Nov 17, 2020
@invidian invidian requested a review from vbatts November 17, 2020 18:25
@invidian
Copy link
Member Author

Oh, it seems it actually can't be used because of etcd magic which is configured here 😞

$ go get github.com/kinvolk/locksmith@ca71ec026997c37cd999c912f464a53ad933da86
go: github.com/flatcar-linux/[email protected] requires
        github.com/coreos/etcd/[email protected]: invalid version: unknown revision 000000000000

@invidian
Copy link
Member Author

Thanks for help @vbatts, but it seems migrating to etcd client v3 is not-trivial so perhaps it can be done some other time.

Not sure what to do with this PR then.

@vbatts
Copy link
Member

vbatts commented Nov 17, 2020 via email

@invidian
Copy link
Member Author

what if we switch it to their v2 client api?

Ah yeah, it seems latest version still provides v2 client API. I changed import paths and it seems to work now 🎉

Also, I'm able to add it as a dependency now to FLUO, but it seems FLUO has actually bigger implementation than here, so it doesn't make much sense to pull it.... Unless we add missing code here for the time being, so we can clean up FLUO and then we deal with locksmith and flatcar/Flatcar#273, what do you think?

In any case, this PR can be merged as it is, tests are passing at least.

@vbatts
Copy link
Member

vbatts commented Nov 18, 2020

i added a basic golang github action. and it passes.
LGTM

@vbatts vbatts merged commit 3f36f3b into flatcar-master Nov 18, 2020
@vbatts vbatts deleted the invidian/update-godbus/dbus branch November 18, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants