-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github.com/godbus/dbus and github.com/coreos/go-systemd #8
Conversation
a684af3
to
ca71ec0
Compare
Oh, it seems it actually can't be used because of etcd magic which is configured here 😞
|
Thanks for help @vbatts, but it seems migrating to etcd client v3 is not-trivial so perhaps it can be done some other time. Not sure what to do with this PR then. |
what if we switch it to their v2 client api?
…On Tue, Nov 17, 2020 at 4:10 PM Mateusz Gozdek ***@***.***> wrote:
Thanks for help @vbatts <https://github.com/vbatts>, but it seems
migrating to etcd client v3 is not-trivial so perhaps it can be done some
other time.
Not sure what to do with this PR then.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQL2IOETEQCTFRAQM2B5DSQLREHANCNFSM4TY5VPCA>
.
--
Vincent Batts
CTO
---
Kinvolk GmbH | Adalbertstr.6a, 10999 Berlin | tel: +491755589364
Geschäftsführer/Directors: Alban Crequy, Chris Kühl, Iago López Galeiras
Registergericht/Court of registration: Amtsgericht Charlottenburg
Registernummer/Registration number: HRB 171414 B
Ust-ID-Nummer/VAT ID number: DE302207000
|
9985d19
to
84cd0b9
Compare
Ah yeah, it seems latest version still provides v2 client API. I changed import paths and it seems to work now 🎉 Also, I'm able to add it as a dependency now to FLUO, but it seems FLUO has actually bigger implementation than here, so it doesn't make much sense to pull it.... Unless we add missing code here for the time being, so we can clean up FLUO and then we deal with locksmith and flatcar/Flatcar#273, what do you think? In any case, this PR can be merged as it is, tests are passing at least. |
Signed-off-by: Mateusz Gozdek <[email protected]>
Co-auther: Mateusz Gozdek <[email protected]> Signed-off-by: Vincent Batts <[email protected]>
84cd0b9
to
1b5eb50
Compare
i added a basic golang github action. and it passes. |
This would be nice to have to be able to make https://github.com/kinvolk/flatcar-linux-update-operator depend on locksmith code as right now it include files which are copy-pasted from this repository and I plan to remove them.
Signed-off-by: Mateusz Gozdek [email protected]