add init.wrapper to force switch to legacy cgroups after initramfs #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
reviewed
Feb 22, 2022
init.wrapper attempts to disable cgroup controllers, unmount cgroup2, and then inject (using a bind mount) additional kernel command line arguments. These kernel parameters are used by systemd to proceed to mount legacy cygroups. We use systemd in the initramfs. If a systemd unit specifies resource control options, systemd will automatically enable the controller for the whole path from unit cgroup to root. This causes the cgroup controller to be busy, and prevents it from being moved from cgroup v2 to cgroup v1. Attempt to remove all cgroups that we can (none of them should have any pids because we just switched_root) and disable any controllers to allow re-binding. Do so before unmounting the initramfs cgroup2 hierarchy.
jepio
force-pushed
the
jepio/runtime-revert-to-cgroupv1
branch
from
ae8ebc3 to
ad77cab
Compare
This was referenced Feb 23, 2022
pothos
approved these changes
Feb 25, 2022
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 1, 2022
…ange This pulls in flatcar/bootengine#35 and flatcar/init#62, which enable boot time switching back to legacy cgroups by creating a flag files (/etc/flatcar-cgroupv1) from ignition.
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 1, 2022
…ange This pulls in flatcar/bootengine#35 and flatcar/init#62, which enable boot time switching back to legacy cgroups by creating a flag files (/etc/flatcar-cgroupv1) from ignition.
jepio
added a commit
that referenced
this pull request
Mar 1, 2022
add init.wrapper to force switch to legacy cgroups after initramfs
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 1, 2022
…ange This pulls in flatcar/bootengine#35 and flatcar/init#62, which enable boot time switching back to legacy cgroups by creating a flag files (/etc/flatcar-cgroupv1) from ignition.
jepio
added a commit
that referenced
this pull request
Mar 17, 2022
add init.wrapper to force switch to legacy cgroups after initramfs
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 17, 2022
…ange This pulls in flatcar/bootengine#35 and flatcar/init#62, which enable boot time switching back to legacy cgroups by creating a flag files (/etc/flatcar-cgroupv1) from ignition. Also contains the subsequent bugfix to coreos-init: c21ee83 "coreos-base/coreos-init: move processes to root cgroup before unbinding controllers"
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 13, 2023
…ange This pulls in flatcar/bootengine#35 and flatcar/init#62, which enable boot time switching back to legacy cgroups by creating a flag files (/etc/flatcar-cgroupv1) from ignition. Also contains the subsequent bugfix to coreos-init: c21ee83df0a2302c0b7cfa375a5f191c14800ec8 "coreos-base/coreos-init: move processes to root cgroup before unbinding controllers"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add init.wrapper to force switch to legacy cgroups after initramfs
init.wrapper attempts to disable cgroup controllers, unmount cgroup2,
and then inject (using a bind mount) additional kernel command line
arguments. These kernel parameters are used by systemd to proceed to
mount legacy cygroups.
How to use
To be used with flatcar/bootengine#35
Testing done
changelog/directory (user-facing change, bug fix, security fix, update)