Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create empty /etc/coreos symlink #28

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

pothos
Copy link
Member

@pothos pothos commented Oct 13, 2020

The symlink had no target and was only working on the final image after
the target folder got created by some other component. Now the target
folder and symlink is created by a tmpfile directive in baselayout and
the symlink here conflicts with the baselayout package's file.
Remove it since it is a duplicate.

How to use

Goes along with flatcar/baselayout#7

Testing done

See linked PR.

The symlink had no target and was only working on the final image after
the target folder got created by some other component. Now the target
folder and symlink is created by a tmpfile directive in baselayout and
the symlink here conflicts with the baselayout package's file.
Remove it since it is a duplicate.
Copy link
Contributor

@margamanterola margamanterola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pothos
Copy link
Member Author

pothos commented Oct 13, 2020

I will include it in all maintenance branches.

@pothos pothos merged commit 1952163 into flatcar-master Oct 13, 2020
@pothos pothos deleted the kai/remove-coreos-symlink branch October 13, 2020 14:04
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Oct 13, 2020
This pulls in
flatcar/init#28 and
flatcar/baselayout#7
to ensure that the /etc/coreos to /etc/flatcar symlink always exists.

Fixes flatcar/Flatcar#190
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Oct 13, 2020
This pulls in
flatcar/init#28 and
flatcar/baselayout#7
to ensure that the /etc/coreos to /etc/flatcar symlink always exists.

Fixes flatcar/Flatcar#190
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Oct 13, 2020
This pulls in
flatcar/init#28 and
flatcar/baselayout#7
to ensure that the /etc/coreos to /etc/flatcar symlink always exists.

Fixes flatcar/Flatcar#190
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Oct 13, 2020
This pulls in
flatcar/init#28 and
flatcar/baselayout#7
to ensure that the /etc/coreos to /etc/flatcar symlink always exists.

Fixes flatcar/Flatcar#190
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Oct 19, 2020
This pulls in
flatcar/init#28 and
flatcar/baselayout#7
to ensure that the /etc/coreos to /etc/flatcar symlink always exists.

Fixes flatcar/Flatcar#190
jepio added a commit that referenced this pull request Feb 21, 2022
dracut: run emergency.target on ignition/torcx service unit failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants