-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not create empty /etc/coreos symlink #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symlink had no target and was only working on the final image after the target folder got created by some other component. Now the target folder and symlink is created by a tmpfile directive in baselayout and the symlink here conflicts with the baselayout package's file. Remove it since it is a duplicate.
margamanterola
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will include it in all maintenance branches. |
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Oct 13, 2020
This pulls in flatcar/init#28 and flatcar/baselayout#7 to ensure that the /etc/coreos to /etc/flatcar symlink always exists. Fixes flatcar/Flatcar#190
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Oct 13, 2020
This pulls in flatcar/init#28 and flatcar/baselayout#7 to ensure that the /etc/coreos to /etc/flatcar symlink always exists. Fixes flatcar/Flatcar#190
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Oct 13, 2020
This pulls in flatcar/init#28 and flatcar/baselayout#7 to ensure that the /etc/coreos to /etc/flatcar symlink always exists. Fixes flatcar/Flatcar#190
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Oct 13, 2020
This pulls in flatcar/init#28 and flatcar/baselayout#7 to ensure that the /etc/coreos to /etc/flatcar symlink always exists. Fixes flatcar/Flatcar#190
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Oct 19, 2020
This pulls in flatcar/init#28 and flatcar/baselayout#7 to ensure that the /etc/coreos to /etc/flatcar symlink always exists. Fixes flatcar/Flatcar#190
jepio
added a commit
that referenced
this pull request
Feb 21, 2022
dracut: run emergency.target on ignition/torcx service unit failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symlink had no target and was only working on the final image after
the target folder got created by some other component. Now the target
folder and symlink is created by a tmpfile directive in baselayout and
the symlink here conflicts with the baselayout package's file.
Remove it since it is a duplicate.
How to use
Goes along with flatcar/baselayout#7
Testing done
See linked PR.