Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatcar-update: Work around a bug in bash 4.3 #119

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

pothos
Copy link
Member

@pothos pothos commented Apr 12, 2024

The use of an empty array in bash 4.3 throws an error if set -u is used. This got fixed later but for old clients we need to have a workaround.

How to use

Update from 2905.2.3 with sudo ./flatcar-update --to-version 3510.3.2

Testing done

The above

The use of an empty array in bash 4.3 throws an error if set -u is used.
This got fixed later but for old clients we need to have a workaround.
@pothos pothos requested a review from a team April 12, 2024 08:44
Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuck, but meh.

:)

@pothos pothos merged commit f35d50b into flatcar-master Apr 12, 2024
@pothos pothos deleted the kai/bash43 branch April 12, 2024 08:52
pothos added a commit to flatcar/scripts that referenced this pull request Apr 12, 2024
This pulls in flatcar/init#119 just to have the
latest commit ref. The change is not needed on new Flatcar versions but
for those that download the flatcar-update script from git as raw file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants