udev: Add rule for /dev/ptp_hyperv systemd unit #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows services (such as chrony) to have a dependency on /dev/ptp_hyperv being present. Inspired by: microsoft/azurelinux#6234. Signed-off-by: Jeremi Piotrowski <[email protected]>
4 tasks
pothos
reviewed
Mar 26, 2024
| @@ -0,0 +1 @@ | |||
| ACTION=="add", SUBSYSTEM=="ptp", ATTR{clock_name}=="hyperv", TAG+="systemd" | |||
There was a problem hiding this comment.
Is there no upstream place where this rule could live?
There was a problem hiding this comment.
Wouldn't this be something for the systemd repo?
There was a problem hiding this comment.
i think not - it's specific to our chronyd configuration.
but if this comes up again or we want to upstream this to other distros we'll find a place then.
pothos
approved these changes
Mar 26, 2024
|
@pothos this rule is actually unnecessary since systemd v255: https://github.com/systemd/systemd/pull/28973/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows services (such as chrony) to have a dependency on /dev/ptp_hyperv being present.
Inspired by: microsoft/azurelinux#6234.