udev: Use $name in issuegen rule #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user is trying to rename network interfaces. This is working but the login issue file still has the initial network interface names. This appears to be similar to thkukuk/issue-generator#6, fix it by using $name instead of $ENV{INTERACE}, so that the rule runs with a changed name. Signed-off-by: Jeremi Piotrowski <[email protected]>
pothos
reviewed
Sep 4, 2023
Yes, i just tested this now. Without this branch renaming from a networkd unit has the same bug. Fixed with this change. |
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 4, 2023
This pulls in flatcar/init#102 which moves the issuegen udev rule to using $name. This lets the rule correctly handle renamed interfaces. Signed-off-by: Jeremi Piotrowski <[email protected]>
2 tasks
pothos
approved these changes
Sep 4, 2023
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 5, 2023
This pulls in flatcar/init#102 which moves the issuegen udev rule to using $name. This lets the rule correctly handle renamed interfaces. Signed-off-by: Jeremi Piotrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
udev: Use $name in issuegen rule
A user is trying to rename network interfaces. This is working but the login issue file still has the initial network interface names. This appears to be similar to thkukuk/issue-generator#6, fix it by using $name instead of $ENV{INTERACE}, so that the rule runs with a changed name.
How to use
Testing done
Ran a qemu vm with the following udev rules:
issue is correct:
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.