Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation on sysext types and origins #348

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

krishjainx
Copy link
Contributor

@krishjainx krishjainx commented Jul 5, 2024

Clarify documentation on sysext types and origins

It's confusing to distinguish between non-official sysexts from the sysext-bakery, built-in sysexts, and official ones. I was often asked about this when giving my talk on systemd system extensions in Berlin. This should clear it up! Thanks :)

EDIT: Closes flatcar/Flatcar#1476

content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash your commits into a single one and we should be good, thanks.

content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
content/docs/latest/provisioning/sysext/_index.md Outdated Show resolved Hide resolved
@krishjainx krishjainx force-pushed the improve-sysext-docs branch 3 times, most recently from ded1bba to 9c562d2 Compare July 10, 2024 08:08
@krishjainx krishjainx requested a review from tormath1 July 10, 2024 08:09
Copy link
Collaborator

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, you still have one pending conflict to solve before merging.

@krishjainx krishjainx requested a review from tormath1 July 10, 2024 08:28
@tormath1
Copy link
Collaborator

There is still an extra commit - instead of merging master into your branch, you can just rebase your commit on master.

@krishjainx
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Documentation around available sysext must be clearer
3 participants