-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: add Krish internship post #273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
reviewed
Jul 25, 2023
tormath1
reviewed
Jul 26, 2023
tormath1
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - can you squash the commits?
krishjainx
force-pushed
the
krish-internship
branch
from
July 27, 2023 10:08
4448b54
to
acabab9
Compare
Done @tormath1 |
tormath1
reviewed
Jul 27, 2023
krishjainx
force-pushed
the
krish-internship
branch
from
July 27, 2023 10:35
acabab9
to
96c37bc
Compare
Done @tormath1
…On Thu, Jul 27, 2023, 15:50 Mathieu Tortuyaux ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On static/media/splash/krish-internship.png
<#273 (comment)>
:
I guess we can drop this picture now?
—
Reply to this email directly, view it on GitHub
<#273 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR4RDLLQEOVJDXX34I5CVKTXSI6HXANCNFSM6AAAAAA2WZVUJU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
tormath1
reviewed
Jul 27, 2023
krishjainx
force-pushed
the
krish-internship
branch
from
July 27, 2023 15:30
7cad7d0
to
3017e44
Compare
tormath1
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blog: add Krish internship post
Add Blog post about my internship experience. Thilo suggested I make a PR
Signed-off-by: Krish Jain [email protected]
Testing done
Followed documentation available on how to create a new blog post and how to test: https://github.com/flatcar/flatcar-website#adding-content