Changed Tutorial 3 config files to support arm architecture #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sayanchowdhury - Please reivew. |
|
Thanks a lot for finding and solving this issue. Instead of having an additional file for M1/M2 laptops, I would suggest to update the |
|
Sure @tormath1, let me send the changes. FYI - I do not have AMD64 machine to test these changes. |
No worries, I'll try on my machine. |
|
@tormath1 - Thanks a lot! Made the changes, please check. |
tormath1
reviewed
Nov 26, 2024
There was a problem hiding this comment.
This file modification can now be dropped.
|
@psrvere thanks for your contribution, this will benefit to M1/M2 users! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing config files throw error for M1/M2 laptops as template provider is not supported for arm. This PR adds two alternate files
compute.tf.armandprovider.tf.armwhich have correct config for M1/M2 laptops. Read me file has also been modified with Instructions.