resty: Add workaround for new curl versions #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
reviewed
Apr 16, 2024
pothos
force-pushed
the
kai/resty-curl
branch
2 times, most recently
from
fb4cc95 to
ea57f47
Compare
The get_package_id function was called with "if" which disabled set -e and thus continued after resty returned an error. The resty function itself doesn't want to be called with set -e and thus we have to wrap the get_package_id call to use set -e while we can explictly react on resty errors which disables set -e. So one time we should not use "if"/"||" and one time we should. While at it, remove the tempfile creation which resulted in many entries that weren't cleaned up and which were confusing because resty also creates some and one doesn't know which is which when debugging.
As Mathieu found out, his new curl version won't process the empty string being passed to curl as argument, resulting from the no-body case for GET. The empty string was treated as additional URL which was skipped over in the past with a warning but now it's a hard error.
|
One can also do the test with |
tormath1
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Mathieu found out, his new curl version won't process the empty string being passed to curl as argument, resulting from the no-body case for GET. The empty string was treated as additional URL which was skipped over in the past with a warning but now it's a hard error.
How to use
Testing done
With
I checked that the
get_package_idshows the error for wrong curl arguments when switching thebody_arg=()assignment to=(--unknown). It now also prints the curl errors when curl hits an HTTP error code which is the case for the final POST in the above test.