upload_package: Don't leak directory name into sha256sums file #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
approved these changes
Sep 27, 2023
The base directory is part of the filename entry in the sha256sums file when it's an absolute path. Don't leak any absolute paths into the checksum file.
pothos
force-pushed
the
kai/only-basename
branch
from
a0eec07 to
98101f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base directory is part of the filename entry in the sha256sums file when it's an absolute path.
Don't leak any absolute paths into the checksum file.
How to use
Use for next release upload
Testing done
None, todo in next release