Add script to create and upload GCP deployment packages to bucket #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayan Chowdhury <[email protected]>
pothos
reviewed
Mar 13, 2023
Comment on lines
+6
to
+7
| FLATCAR_GCP_DEPLOYMENT_PACKAGE=${FLATCAR_GCP_DEPLOYMENT_PACKAGE:-${FLATCAR_GCP_DEPLOYMENT_PACKAGE_NAME}.zip} | ||
| FLATCAR_GCP_DEPLOYMENT_PACKAGE_URL=${FLATCAR_GCP_DEPLOYMENT_PACKAGE_URL:-https://mirror.release.flatcar-linux.net/coreos/} |
There was a problem hiding this comment.
I would rather add this folder here as subfolder instead of having to maintain that remote zip file. Currently the REGEX_TMPL comes out of nowhere if one can't easily read the template it works on.
pothos
reviewed
Mar 13, 2023
| done | ||
|
|
||
| # zip the contents of the directory | ||
| local c_date=$(date +%Y%m%d) |
There was a problem hiding this comment.
Suggested change
| local c_date=$(date +%Y%m%d) | |
| local c_date | |
| c_date=$(date +%Y%m%d) |
local hides any failures
pothos
reviewed
Mar 13, 2023
| -d ${WORK_DIR}/${FLATCAR_GCP_DEPLOYMENT_PACKAGE_NAME} | ||
|
|
||
| for channel in stable beta alpha; do | ||
| local ver=$(get_version "${channel}") |
There was a problem hiding this comment.
Suggested change
| local ver=$(get_version "${channel}") | |
| local ver | |
| ver=$(get_version "${channel}") |
local hides any failures
pothos
reviewed
Mar 13, 2023
| } | ||
|
|
||
| get_version() { | ||
| local channel=$1 |
There was a problem hiding this comment.
Suggested change
| local channel=$1 | |
| local channel="$1" |
|
Closing this since https://github.com/flatcar/flatcar-maintainer-private/pull/11 has been merged and the script in this PR is now part of https://github.com/flatcar/flatcar-maintainer-private/tree/main/documentation/maintenance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add script to create and upload GCP deployment packages to bucket
To be merged with https://github.com/kinvolk/PROJECT-flatcar-linux/pull/555