Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for Proxmox support #91

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Draft for Proxmox support #91

merged 2 commits into from
Nov 12, 2024

Conversation

pothos
Copy link
Member

@pothos pothos commented Mar 22, 2024

This makes use of coreos/afterburn#1023 to set up any static networking from the initrd (for Ignition) and the hostname (early enough so that Ignition could overwrite it).

Testing done

Tested with Flatcar community: flatcar/Flatcar#1573 (reply in thread)

pothos added a commit to flatcar/scripts that referenced this pull request Mar 22, 2024
This uses coreos/afterburn#1023 to provide
Proxmox images. TODO: Add Ignition PR.

This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup.
pothos added a commit to flatcar/scripts that referenced this pull request Mar 22, 2024
This uses coreos/afterburn#1023 to provide
Proxmox images. TODO: Add Ignition PR.

This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup.
pothos added a commit to flatcar/scripts that referenced this pull request Mar 22, 2024
This uses coreos/afterburn#1023 to provide
Proxmox images. TODO: Add Ignition PR.

This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup.
@pothos
Copy link
Member Author

pothos commented Apr 24, 2024

I think we have to close this because this relies on cloud-init userdata and because Flatcar will run coreos-cloudinit anyway if it doesn't see Ignition user-data we would have it processed twice. For the network config that can be quite confusing because the afterburn network unit would only support a subset.

@pothos
Copy link
Member Author

pothos commented Apr 24, 2024

I think we have to close this because this relies on cloud-init userdata and because Flatcar will run coreos-cloudinit anyway if it doesn't see Ignition user-data we would have it processed twice. For the network config that can be quite confusing because the afterburn network unit would only support a subset.

Or not because the configdrive has two files, and afterburn could be used for network-config while we leave user-data to Ignition/coreos-cloudinit (through the configdrive unit trigger).

pothos added a commit to flatcar/scripts that referenced this pull request May 6, 2024
This uses coreos/afterburn#1023 and
coreos/ignition#1790 to provide
Proxmox images.

This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup. The afterburn
support for the SSH key and hostname parses the user-data when it's
cloud-init. The coreos-cloudinit support is not there but can be added
in addition: We need to add a new provider that varies from the existing
config drive support because the file is called user-data and not
user_data, and it needs to look for a filesystem label cidata and not
config-2.
@pothos pothos force-pushed the kai/proxmox-support branch from 8a9d244 to 700e217 Compare May 6, 2024 13:18
pothos added a commit to flatcar/scripts that referenced this pull request May 6, 2024
This uses coreos/afterburn#1023 and
coreos/ignition#1790 to provide
Proxmox images.

This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup. The afterburn
support for the SSH key and hostname parses the user-data when it's
cloud-init. The coreos-cloudinit support is not there but can be added
in addition: We need to add a new provider that varies from the existing
config drive support because the file is called user-data and not
user_data, and it needs to look for a filesystem label cidata and not
config-2.
tormath1 pushed a commit to flatcar/scripts that referenced this pull request May 27, 2024
This uses coreos/afterburn#1023 and
coreos/ignition#1790 to provide
Proxmox images.

This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup. The afterburn
support for the SSH key and hostname parses the user-data when it's
cloud-init. The coreos-cloudinit support is not there but can be added
in addition: We need to add a new provider that varies from the existing
config drive support because the file is called user-data and not
user_data, and it needs to look for a filesystem label cidata and not
config-2.
tormath1 pushed a commit to flatcar/scripts that referenced this pull request May 30, 2024
This uses coreos/afterburn#1023 and
coreos/ignition#1790 to provide
Proxmox images.

This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup. The afterburn
support for the SSH key and hostname parses the user-data when it's
cloud-init. The coreos-cloudinit support is not there but can be added
in addition: We need to add a new provider that varies from the existing
config drive support because the file is called user-data and not
user_data, and it needs to look for a filesystem label cidata and not
config-2.
tormath1 pushed a commit to flatcar/scripts that referenced this pull request May 30, 2024
This uses coreos/afterburn#1023 and
coreos/ignition#1790 to provide
Proxmox images.

This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup. The afterburn
support for the SSH key and hostname parses the user-data when it's
cloud-init. The coreos-cloudinit support is not there but can be added
in addition: We need to add a new provider that varies from the existing
config drive support because the file is called user-data and not
user_data, and it needs to look for a filesystem label cidata and not
config-2.
tormath1 pushed a commit to flatcar/scripts that referenced this pull request Jun 7, 2024
This uses coreos/afterburn#1023 and
coreos/ignition#1790 to provide
Proxmox images.

This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup. The afterburn
support for the SSH key and hostname parses the user-data when it's
cloud-init. The coreos-cloudinit support is not there but can be added
in addition: We need to add a new provider that varies from the existing
config drive support because the file is called user-data and not
user_data, and it needs to look for a filesystem label cidata and not
config-2.
@tormath1 tormath1 force-pushed the kai/proxmox-support branch from 700e217 to 10357a3 Compare August 17, 2024 16:15
@tormath1 tormath1 force-pushed the kai/proxmox-support branch from 10357a3 to 69cf455 Compare October 24, 2024 13:00
This makes use of afterburn to set up any static networking
from the initrd (for Ignition) and the hostname (early enough so that Ignition could overwrite it).

Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 force-pushed the kai/proxmox-support branch from 69cf455 to 6afdb03 Compare November 8, 2024 08:31
…rburn

This is used by proxmox too so it does not make sense to keep this name

Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 force-pushed the kai/proxmox-support branch from 6afdb03 to 2607689 Compare November 8, 2024 08:33
@tormath1 tormath1 self-assigned this Nov 8, 2024
@tormath1 tormath1 requested a review from a team November 8, 2024 08:34
@tormath1 tormath1 merged commit c9de038 into flatcar-master Nov 12, 2024
@tormath1 tormath1 deleted the kai/proxmox-support branch November 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants