-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network: Disable RoutesToDNS #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flatcar VMs on Azure with multiple nics fail to provision correctly because of multiple routes to wireserver (168.63.129.16) with the same metric, and wireserver only responds to 'ready' signals on the primary nic. The primary nic gets an explicit route to wireserver through dhcp. It turns out systemd is adding the extra routes because wireserver is also the dhcp and dns server, and the default RoutesToDNS=true setting is the reason. This behavior is non-standard and I don't think it's expected on any platform. Disable this behavior by default. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 4, 2023
Pull in this PR flatcar/bootengine#74 to disable a systemd-networkd setting causing unexpected routes to appear. Signed-off-by: Jeremi Piotrowski <[email protected]>
2 tasks
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 4, 2023
Pull in this PR flatcar/bootengine#74 to disable a systemd-networkd setting causing unexpected routes to appear. Signed-off-by: Jeremi Piotrowski <[email protected]>
pothos
approved these changes
Oct 6, 2023
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 9, 2023
Pull in this PR flatcar/bootengine#74 to disable a systemd-networkd setting causing unexpected routes to appear. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 10, 2023
Pull in this PR flatcar/bootengine#74 to disable a systemd-networkd setting causing unexpected routes to appear. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 11, 2023
Pull in this PR flatcar/bootengine#74 to disable a systemd-networkd setting causing unexpected routes to appear. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 12, 2023
Pull in this PR flatcar/bootengine#74 to disable a systemd-networkd setting causing unexpected routes to appear. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 12, 2023
Pull in this PR flatcar/bootengine#74 to disable a systemd-networkd setting causing unexpected routes to appear. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 12, 2023
Pull in this PR flatcar/bootengine#74 to disable a systemd-networkd setting causing unexpected routes to appear. Signed-off-by: Jeremi Piotrowski <[email protected]>
sayanchowdhury
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 17, 2023
Pull in this PR flatcar/bootengine#74 to disable a systemd-networkd setting causing unexpected routes to appear. Co-authored-by: Jeremi Piotrowski <[email protected]> Signed-off-by: Sayan Chowdhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network: Disable RoutesToDNS
Flatcar VMs on Azure with multiple nics fail to provision correctly because of multiple routes to wireserver (168.63.129.16) with the same metric, and wireserver only responds to 'ready' signals on the primary nic. The primary nic gets an explicit route to wireserver through dhcp. It turns out systemd is adding the extra routes because wireserver is also the dhcp and dns server, and the default RoutesToDNS=true setting is the reason.
This behavior is non-standard and I don't think it's expected on any platform. Disable this behavior by default.
How to use
az vm create --nics ...
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.