Initial cleanups #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the changes here come from renaming read and write functions from WriteStuff and ReadStuff to WriteStuffAt and ReadStuffAt, respectively, so that go vet won't complain about certain functions with standard names having unexpected, non-standard prototype.
Rebuild the utility when go.mod, go.sum or Makefile gets changed. Add a clean target.
|
Can't assign @flatcar/flatcar-maintainers as reviewers, so mentioning the team here. |
tormath1
approved these changes
May 23, 2024
|
Looks like I can't "officially" approve. BTW, why are we forking this repository? |
jepio
approved these changes
May 23, 2024
The upstream is dead - last code commit was in 2018. Maybe eventually we could revive it and even get commit rights to the original repo, but I have no idea what processes are there and how long would it take. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the project to
github.com/flatcar/azure-vhd-utils, fixesgofmt,go vetandgo mod tidyissues.The follow-up PR will port the project to the new Azure SDK.
The project will be used by mantle to handle uploading VHD images to Azure.