-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
Looks good if CI passed. Can you please also delete rng-tools from https://github.com/flatcar-linux/coreos-overlay/blob/233d43aa144dfa508739d4b31644478919591cef/profiles/coreos/arm64/package.accept_keywords#L57 ? |
Mm, polkit build is failing because of this I think: https://mesonbuild.com/Release-notes-for-0-60-0.html#unknown-options-are-now-always-fatal. EDIT: build has been retriggered with this commit: flatcar-archive/coreos-overlay@7e303cc |
Thanks @tormath1 , can you submit the duktape fix as a PR? The remaining issue is that now the rngd service exits with error when hwrng is not available, so i'll adjust the |
Is rngd now starting by default or still only in the initramfs? We had a discussion in in flatcar/Flatcar#207 about that. I think it won't hurt to try to run it and handle it gracefully. Another idea was to only start it based on seeing what |
Yes, we automatically enable rngd but only for the initramfs (https://github.com/dracutdevs/dracut/blob/master/modules.d/06rngd/module-setup.sh). |
Ok, should we enable it by default then in general instead of only the initramfs? |
With the new development I hope yes, it won't be needed anymore: https://lwn.net/Articles/884875/ |
@JAORMX might be right - I will test removing rngd altogether. There were many changes to kernel rng other the year,s most of which have the goal of removing blocking. |
Sync meson and keep only the current stable ebuild (0.60.3). Upstream commit 83cf9e2749be378ca4bb12096c2a33093a0af998 Signed-off-by: Jeremi Piotrowski <[email protected]>
0331914
to
bdb9b1c
Compare
Dropped the rng-tools part because we removed it. Rerunning CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's wait for the CI but it's a "go" for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if it has changelog as well.
EDIT: ah, no changelog is needed, as it is just meson.
update meson
Update meson to a current version, which is needed when introducing clevis ebuilds.
How to use
./build_packages && ./build_image
Testing done
CI running: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/4810/cldsv/
changelog/
directory (user-facing change, bug fix, security fix, update)