Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

update meson #285

Merged
merged 1 commit into from
Mar 18, 2022
Merged

update meson #285

merged 1 commit into from
Mar 18, 2022

Conversation

jepio
Copy link
Contributor

@jepio jepio commented Feb 10, 2022

update meson

Update meson to a current version, which is needed when introducing clevis ebuilds.

How to use

./build_packages && ./build_image

Testing done

CI running: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/4810/cldsv/

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

@jepio jepio changed the title update rng tools and meson update rng-tools and meson Feb 10, 2022
@jepio jepio requested a review from a team February 10, 2022 16:10
@dongsupark
Copy link
Contributor

@tormath1
Copy link
Contributor

tormath1 commented Feb 10, 2022

Mm, polkit build is failing because of this I think: https://mesonbuild.com/Release-notes-for-0-60-0.html#unknown-options-are-now-always-fatal.
I think we could replace the useless -Dwith-duktape=yes by this option: https://gitlab.freedesktop.org/polkit/polkit/-/blob/master/meson_options.txt#L19. It was correctly built previously because the option seems to default to duktape.

EDIT: build has been retriggered with this commit: flatcar-archive/coreos-overlay@7e303cc

@jepio
Copy link
Contributor Author

jepio commented Feb 11, 2022

Thanks @tormath1 , can you submit the duktape fix as a PR? The remaining issue is that now the rngd service exits with error when hwrng is not available, so i'll adjust the ExecStart line to tolerate failure.

@pothos
Copy link
Contributor

pothos commented Feb 11, 2022

Is rngd now starting by default or still only in the initramfs? We had a discussion in in flatcar/Flatcar#207 about that. I think it won't hurt to try to run it and handle it gracefully. Another idea was to only start it based on seeing what /dev/random is backed by /sys/class/misc/hw_random/rng_* and whether rngd adds value or not but that is maybe a bit complex.

@jepio
Copy link
Contributor Author

jepio commented Feb 11, 2022

Yes, we automatically enable rngd but only for the initramfs (https://github.com/dracutdevs/dracut/blob/master/modules.d/06rngd/module-setup.sh). /sys/class/misc/hw_random/rng_* is related to /dev/hwrng but these don't get fed into /dev/random automatically, that's what rngd does. rngd support multiple backends and on x86 it uses the rdrand instruction. The new version also can checks whether /dev/hwrng has an backend before using.

@pothos
Copy link
Contributor

pothos commented Feb 11, 2022

Ok, should we enable it by default then in general instead of only the initramfs?

@JAORMX
Copy link
Contributor

JAORMX commented Feb 22, 2022

uhm... isn't it the case that rngd is no longer needed? At least it doesn't seem to be shipping anymore in Fedora [1] [2], and RHEL [3]

@pothos
Copy link
Contributor

pothos commented Feb 22, 2022

uhm... isn't it the case that rngd is no longer needed? At least it doesn't seem to be shipping anymore in Fedora [1] [2], and RHEL [3]

With the new development I hope yes, it won't be needed anymore: https://lwn.net/Articles/884875/

@jepio
Copy link
Contributor Author

jepio commented Feb 22, 2022

@JAORMX might be right - I will test removing rngd altogether. There were many changes to kernel rng other the year,s most of which have the goal of removing blocking.

Sync meson and keep only the current stable ebuild (0.60.3).

Upstream commit 83cf9e2749be378ca4bb12096c2a33093a0af998

Signed-off-by: Jeremi Piotrowski <[email protected]>
@jepio jepio force-pushed the jepio/update-rng-tools-and-meson branch from 0331914 to bdb9b1c Compare March 18, 2022 11:54
@jepio jepio changed the title update rng-tools and meson update meson Mar 18, 2022
@jepio
Copy link
Contributor Author

jepio commented Mar 18, 2022

Dropped the rng-tools part because we removed it. Rerunning CI.

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for the CI but it's a "go" for me.

Copy link
Contributor

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if it has changelog as well.

EDIT: ah, no changelog is needed, as it is just meson.

@jepio jepio merged commit f8532e4 into main Mar 18, 2022
@jepio jepio deleted the jepio/update-rng-tools-and-meson branch March 18, 2022 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants