Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Upgrade git 2.32.0 #224

Merged

Conversation

ArkaprabhaChakraborty
Copy link
Contributor

@ArkaprabhaChakraborty ArkaprabhaChakraborty commented Sep 29, 2021

Testing done

cat developer-latest/flatcar_production_image_packages.txt | grep git
dev-vcs/git-2.32.0-r1::portage-stable

CI passed: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3812/cldsv

@dongsupark
Copy link
Contributor

Thanks for the PR.
Code looks good.

Commit message and the PR description have git 2.32.0, while the PR title has 2.31.1.
I am fine with any version, either 2.31.1 or 2.32.0.
But can you please fix one of the versions, so it can be consistent?

@ArkaprabhaChakraborty
Copy link
Contributor Author

Thanks for the PR. Code looks good.

Commit message and the PR description have git 2.32.0, while the PR title has 2.31.1. I am fine with any version, either 2.31.1 or 2.32.0. But can you please fix one of the versions, so it can be consistent?

it's 2.32.0 final

@ArkaprabhaChakraborty
Copy link
Contributor Author

I updated the package and also got 2.33.0 :) but it was unstable for amd64 and arm gr so I didn't add it in package names (packages.accept_keywords).

@ArkaprabhaChakraborty
Copy link
Contributor Author

I made the PR before actually working out a build. When I made a custom image I saw git 2.32.0 was there and the build script took it by default so I just amended my commit message to git 2.32.0. :)

@dongsupark dongsupark changed the title Upgrade git 2.31.1 Upgrade git 2.32.0 Sep 30, 2021
@dongsupark
Copy link
Contributor

All right, I fixed the PR title.

@sayanchowdhury
Copy link
Contributor

@ArkaprabhaChakraborty
Copy link
Contributor Author

🙂

@krnowak
Copy link
Contributor

krnowak commented Oct 8, 2021

@ArkaprabhaChakraborty : Hi, sorry for being slow on your PRs recently - we are working on flatcar/Flatcar#523, which is a priority for us. We should be finished with it next week.

Copy link
Contributor

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed, except for unrelated failures: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3812/cldsv
Thanks a lot for the contribution.

@dongsupark dongsupark merged commit 9b731a0 into flatcar-archive:main Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants