Skip to content
This repository has been archived by the owner on Oct 26, 2023. It is now read-only.

kubernetes: add sysext documentation #338

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Sep 26, 2023

I tried to make it dynamic using the tab feature, defaulting to the Sysext approach.

@tormath1 tormath1 self-assigned this Sep 26, 2023
:warning: To ease the reading, we voluntarily omitted the checksums of the downloaded artifacts.

```yaml
Here's an example with [butane][butane] to setup a control plane using the Systemd sysext approach or the binaries approach.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here's an example with [butane][butane] to setup a control plane using the Systemd sysext approach or the binaries approach.
Here are two examples to setup a control plane with [Butane][butane]. The first example is using the systemd-sysext approach to bring in the binaries and update them through systemd-sysupdate. The second approach fetches the binaries but has no way of updating them in-place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are gone because the addition of /etc/sysupdate.kubernetes.d/kubernetes.conf and the force push flushed them^^ https://github.com/flatcar/flatcar-docs/compare/2e44a5af9434779c7172b276b9fd4f4fcd24a398..a3ec8195b004ced01d8b397d82e1400a09b7bcc2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah !!! Forgot to rebase before pushing. Thanks for the heads up :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can get the commit from the reflog or from github :D

- name: kubernetes.conf
contents: |
[Service]
ExecStartPre=/usr/lib/systemd/systemd-sysupdate -C kubernetes update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we run refresh here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's still the question of handling the update. We could show in the documentation an example using KureD for example.
Or we can simply run refresh and systemctl restart kubelet but not sure it's the right way to upgrade a Kubernetes node.

Copy link
Contributor

@pothos pothos Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing the touch for kured sounds good (maybe an env var can first capture the symlink target, so that the ExecStartPost can compare this).

Copy link
Contributor Author

@tormath1 tormath1 Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Kured example with symlink comparison.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's good :) Any tweaks to how that is done can also be added later.

@tormath1 tormath1 force-pushed the tormath1/kubernetes-sysext branch 2 times, most recently from a3ec819 to 168e4b1 Compare September 29, 2023 12:35
Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 force-pushed the tormath1/kubernetes-sysext branch from 168e4b1 to e7ff156 Compare October 4, 2023 09:59
@tormath1 tormath1 marked this pull request as ready for review October 4, 2023 10:04
@tormath1 tormath1 requested a review from a team October 4, 2023 10:04
@tormath1 tormath1 merged commit a33a02b into main Oct 4, 2023
@tormath1 tormath1 deleted the tormath1/kubernetes-sysext branch October 4, 2023 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants