Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

sys-apps/ignition: bump commit ID #1249

Merged
merged 5 commits into from
Mar 7, 2022
Merged

sys-apps/ignition: bump commit ID #1249

merged 5 commits into from
Mar 7, 2022

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Sep 2, 2021

this commit ID pulls the following PR:

it mainly brings V3 support on top of V2 support for Ignition and ensure
backward compatibility with existing integration.

Signed-off-by: Mathieu Tortuyaux [email protected]

How to use

emerge-amd64-usr -v sys-apps/ignition
emerge-amd64-usr coreos-kernel
./build_image

TODO: add v3 support to ct or use a flatcar variant for Butane configs https://github.com/coreos/butane/

Testing done

Note for reviewers

To be merged with:

Related to: flatcar/Flatcar#387

@tormath1 tormath1 self-assigned this Sep 2, 2021
@tormath1 tormath1 marked this pull request as draft September 2, 2021 08:50
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch 5 times, most recently from 600b9cc to 67410bd Compare September 10, 2021 09:54
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch from 67410bd to 6fe2ddb Compare September 15, 2021 11:52
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch 4 times, most recently from 1a33bdf to 5e4442e Compare September 29, 2021 12:44
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch from 5e4442e to 668755d Compare January 7, 2022 15:40
@tormath1 tormath1 removed the alpha label Jan 7, 2022
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch 2 times, most recently from 25488b5 to 56c957b Compare February 1, 2022 18:06
@pothos pothos force-pushed the tormath1/ignition-bump branch from 56c957b to c0c650e Compare February 2, 2022 09:54
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch 5 times, most recently from 0c5376e to e2a588b Compare February 8, 2022 21:06
@pothos
Copy link
Contributor

pothos commented Feb 10, 2022

In the flatcar/bootengine#34 PR we also need to use the new content of the dracut/30ignition folder

@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch from e2a588b to 4bc3ca8 Compare February 10, 2022 18:05
@pothos
Copy link
Contributor

pothos commented Feb 10, 2022

Not sure how visible a comment on a commit is, here a link to it: flatcar/init@c68347d#r66442674

@tormath1
Copy link
Contributor Author

Not sure how visible a comment on a commit is, here a link to it: flatcar-linux/init@c68347d#r66442674

Opened a PR for better visibility: flatcar/init#60, comments on the commit have been added to the discussion.

@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch 2 times, most recently from 6048bbb to a4f9217 Compare February 25, 2022 13:42
@pothos pothos force-pushed the tormath1/ignition-bump branch from b69d16a to 4564b15 Compare February 28, 2022 13:54
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch 3 times, most recently from 971e99d to 3eb8f47 Compare March 2, 2022 18:26
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch 2 times, most recently from b8288f6 to d84c4fa Compare March 3, 2022 16:23
@pothos
Copy link
Contributor

pothos commented Mar 7, 2022

Some things to mention in the changelog entry:

  • v1 and v2 are still supported and get translated at runtime; while this is tested well there may be corner cases where the v2 config relied on unspecified behavior
  • clevis not supported
  • kargs is supported and will persist the changes in /usr/share/oem/grub.cfg before the reboot but it only works for unconditional set linux_append statements in grub.cfg and linux_console is not considered
  • ct can't emit Ignition v3 yet and we have not yet defined a variant for Butane

@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch from d84c4fa to 0300783 Compare March 7, 2022 11:09
@tormath1
Copy link
Contributor Author

tormath1 commented Mar 7, 2022

Some things to mention in the changelog entry:

* v1 and v2 are still supported and get translated at runtime; while this is tested well there may be corner cases where the v2 config relied on unspecified behavior

* clevis not supported

* kargs is supported and will persist the changes in `/usr/share/oem/grub.cfg` before the reboot but it only works for unconditional `set linux_append` statements in `grub.cfg` and `linux_console` is not considered

* `ct` can't emit Ignition v3 yet and we have not yet defined a variant for Butane

@pothos quid of having the following items into Flatcar documentation and only link the documentation into release notes ?

@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch from 0300783 to 4d58c78 Compare March 7, 2022 17:00
@tormath1 tormath1 changed the title [wip] sys-apps/ignition: bump commit ID sys-apps/ignition: bump commit ID Mar 7, 2022
@tormath1 tormath1 marked this pull request as ready for review March 7, 2022 17:03
@@ -0,0 +1 @@
ignition-9999.ebuild
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the other symlink

Mathieu Tortuyaux and others added 4 commits March 7, 2022 18:17
it mainly brings V3 support on top of V2 support for Ignition and ensure
backward compatibility with existing integration.

Signed-off-by: Mathieu Tortuyaux <[email protected]>
With ignitionv3, there is no more `default.ign` loaded configuration. We
can safely remove this configuration since it won't be loaded anyway.

oem-cloudinit will be conditionally enabled based on `ignition`
execution result.

Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch from 4d58c78 to 0f6a5b0 Compare March 7, 2022 17:17
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Co-authored-by: Kai Lüke <[email protected]>
@tormath1 tormath1 force-pushed the tormath1/ignition-bump branch from 7e6b46b to fc31ebd Compare March 7, 2022 17:33
@tormath1 tormath1 merged commit 3f69ac4 into main Mar 7, 2022
@tormath1 tormath1 deleted the tormath1/ignition-bump branch March 7, 2022 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants