This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Update deps, and fix two warnings #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Batts <[email protected]>
invidian
reviewed
Mar 8, 2021
| @@ -1,2001 +1,2001 @@ | |||
| # This file is automatically @generated by Cargo. | |||
There was a problem hiding this comment.
It seems to be this doesn't update any dependencies, but only format of Cargo.lock file. I guess https://github.com/kinvolk/afterburn/blob/flatcar-master/Cargo.toml would have to be modified to update the dependencies.
There was a problem hiding this comment.
Depends on whether the versions are specified exactly in Cargo.toml this here can pull in updates. I didn't look if that's the case but anyway we need to make changes in the ebuild file if we want to update some dependency version. Also it's always good to test if the ebuild still works when you do changes in a project and bump the ebuild to the latest commit, or it becomes a trap for the next person woring on it.
- fix the bare provider
- remove redundant import of tempfile
on rustc 1.50.0 (cb75ad5db 2021-02-10):
```shell
warning: trait objects without an explicit `dyn` are deprecated
--> src/metadata.rs:36:61
|
36 | pub fn fetch_metadata(provider: &str) -> errors::Result<Box<providers::MetadataProvider>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn providers::MetadataProvider`
|
= note: `#[warn(bare_trait_objects)]` on by default
warning: the item `tempfile` is imported redundantly
--> src/providers/mod.rs:101:9
|
101 | use tempfile;
| ^^^^^^^^
|
::: src/main.rs:39:1
|
39 | extern crate tempfile;
| ---------------------- the item `tempfile` is already imported here
|
= note: `#[warn(unused_imports)]` on by default
```
Signed-off-by: Vincent Batts <[email protected]>
dongsupark
approved these changes
May 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Batts [email protected]