-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5 Extend with Buld action and Image generator #6
base: main
Are you sure you want to change the base?
Conversation
Could you check this output of GitHub Actions ? It looks not good, it has extra slash(/). Everything else looks good. Especially, It is very good to add test 👍 |
I looked at it, but it needs a bit more complexity to the input validation. I tried to avoid that and just tested it with too many slashes in every input. But I agree the output would look better. I have a look tomorrow |
@flat35hd99 , sorry I lied ;) i looked at it today 🎉 |
Hi, could you have a look at the Pr |
Hey I just wanted to comment and hopefully help. I think @flat35hd99 is saying when you do a basic request for png file depending on your file it doesn't look good, not that there are extra /'s in the file name. This is because by default openscad when trying to render pngs using the command line just does a "preview mode(F5)" render. If you add the option into the command line --render it will actually do it as if you did a full render(F6) like what you do when you want to export the actual stl. I have tested this in my repo with some surfaces that were "differenced" away right at the surface they look bad. currently I'm using the work around of adding the --render option manually but if you added it automatically in entrypoint.sh in your if "$target_format_for_bulk" == "png" code block into the $options then they would always come out better looking |
What happened to this? No activity in half a year, even tho this seems like something significant |
#5