Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix media info collection without a source object #19

Open
wants to merge 1 commit into
base: wcs_api-2.0
Choose a base branch
from
Open

Fix media info collection without a source object #19

wants to merge 1 commit into from

Conversation

Azarattum
Copy link

We were receiving consistent sentry reports with the following error:

null is not an object (evaluating 'localVideo.srcObject.getAudioTracks')

The exact reproduction is unclear, though the fix in this PR should be pretty straightforward.

@flashphoner
Copy link
Owner

Hello.
The fix is acceptable. We raised the ticket WCS-4239 to test and apply it.

flashphoner added a commit that referenced this pull request Sep 23, 2024
@flashphoner
Apply PR #19 from GitHub #WCS-4239
1dee47a
@flashphoner
Copy link
Owner

We applied the changes. Sentry should not report the error anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azarattum @flashphoner