Event log: enable custom timestamp (via message prefix) #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Allow custom timestamps in the event log.
If a message is prefixed with a timestamp (in sec or ms), then that part is used for
ReceivedAt
and the message is the remainder of the original message:Motivation
Some services might log into an (async) named pipe already before system-api has started. Without custom timestamps, those log entries would all have the timestamp when system-api started, instead of when the log message was written.
Downsides
Allows services to mess with internals through the log message, and spoof the timestamp of it's own event arbitrarily.
Discussion
Not yet sure what's the best path forward -- giving services this freedom, or simply not having 'proper' timestamps for logs received before system-api start.
✅ I have run these commands
make lint
make test
go mod tidy