Add genesis time for testnets #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
reviewed
Jun 27, 2023
avalonche
reviewed
Jun 27, 2023
cli/main.go
Outdated
| mainnet = flag.Bool("mainnet", true, "use Mainnet") | ||
| sepolia = flag.Bool("sepolia", defaultUseSepolia, "use Sepolia") | ||
| goerli = flag.Bool("goerli", defaultUseGoerli, "use Goerli") | ||
| zhejiang = flag.Bool("zhejiang", defaultUseZhejiang, "use Zhejiang") |
There was a problem hiding this comment.
Zhejiang is deprecated, can be removed
avalonche
reviewed
Jun 27, 2023
avalonche
reviewed
Jun 27, 2023
server/service.go
Outdated
| @@ -62,6 +62,7 @@ type BoostServiceOpts struct { | |||
| Relays []RelayEntry | |||
| RelayMonitors []*url.URL | |||
| GenesisForkVersionHex string | |||
| GenesisTime int64 | |||
There was a problem hiding this comment.
I add a commit for that. However at the end, time.Now().UTC().UnixMilli() is int64 not uint64, so we still need a cast. IMO it would be better to consider all times as int64.
|
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #540 +/- ##
===========================================
- Coverage 70.24% 70.16% -0.08%
===========================================
Files 6 7 +1
Lines 541 1106 +565
===========================================
+ Hits 380 776 +396
- Misses 132 285 +153
- Partials 29 45 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
nice addition, btw -- thanks for the contribution 👍 |
|
btw, please fix the linter too |
|
metachris
reviewed
Jun 27, 2023
cli/main.go
Outdated
| } | ||
| log.Infof("using genesis fork version: %s", genesisForkVersionHex) | ||
|
|
||
| switch { |
There was a problem hiding this comment.
don't add a second switch here, assign the time in the switch above, and then below just do a simple if *useCustomGenesisTime > -1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Display
getHeader request start - %d milliseconds into slot %dandsubmitBlindedBlock request start - %d milliseconds into slot %dcorrectly only by setting the-<testnet-name>CLI option.Example with
-sepolia:Design note
I removed the ability to set the genesis time by setting
GENESIS_TIMESTAMPenvironment variable.If requested, I can add a
-genesis-timestampCLI option, as done with-genesis-fork-versionCLI option.✅ I have run these commands
make lint==>golangci-lint runcannot run it ondevelopbranchmake test-racego mod tidy