log slot-uid #536
Merged
log slot-uid #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
β Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #536 +/- ##
===========================================
- Coverage 70.24% 69.84% -0.40%
===========================================
Files 6 8 +2
Lines 541 1290 +749
===========================================
+ Hits 380 901 +521
- Misses 132 340 +208
- Partials 29 49 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaelneuder
previously approved these changes
Jun 22, 2023
server/service.go
Outdated
| @@ -348,6 +339,16 @@ func (m *BoostService) handleGetHeader(w http.ResponseWriter, req *http.Request) | |||
| } | |||
| uid := m.slotUID.uid | |||
| m.slotUIDLock.Unlock() | |||
| log = log.WithField("slotUid", uid) | |||
There was a problem hiding this comment.
nit: slotUID for consistency?
server/service.go
Outdated
| // Prepare logger | ||
| ua := UserAgent(req.Header.Get("User-Agent")) | ||
| log = log.WithFields(logrus.Fields{ | ||
| "ua": ua, | ||
| "slot": payload.Message.Slot, | ||
| "blockHash": payload.Message.Body.ExecutionPayloadHeader.BlockHash.String(), | ||
| "parentHash": payload.Message.Body.ExecutionPayloadHeader.ParentHash.String(), | ||
| "slotUid": uid, |
There was a problem hiding this comment.
same comment as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Instead of just sending it as part of the request, also log the slot uid with the getHeader/getPayload log messages. This should further help debugging.
β I have run these commands
make lintmake test-racego mod tidy