Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade getHeader for capella with fallback to bellatrix encoding #442

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

avalonche
Copy link
Collaborator

@avalonche avalonche commented Feb 1, 2023

📝 Summary

⛱ Motivation and Context

📚 References


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

Codecov Report

Merging #442 (ff22e15) into main (cbea39d) will increase coverage by 1.40%.
The diff coverage is 79.31%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   65.39%   66.80%   +1.40%     
==========================================
  Files           7        8       +1     
  Lines        1049     1211     +162     
==========================================
+ Hits          686      809     +123     
- Misses        315      353      +38     
- Partials       48       49       +1     
Flag Coverage Δ
unittests 66.80% <79.31%> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/utils.go 75.00% <ø> (ø)
server/types.go 70.00% <70.00%> (ø)
server/mock_relay.go 85.86% <94.23%> (+0.95%) ⬆️
server/service.go 74.90% <100.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@avalonche avalonche marked this pull request as ready for review February 9, 2023 06:52
@metachris metachris merged commit f7cbae4 into main Feb 13, 2023
@metachris metachris deleted the capella-get-header branch February 13, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants