-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: added instructions for -min-bid #417
Conversation
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage 65.93% 65.93%
=======================================
Files 7 7
Lines 907 907
=======================================
Hits 598 598
Misses 274 274
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2a1217f
to
96a1a11
Compare
96a1a11
to
cdf731d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to add this to the readme! Just a few little nits.
whooos, sorry the requests for changes were just below the approval notice, and the merge button was green, so i merged it. will post a PR with the changes, thx @jtraglia |
No worries! Thanks. |
📝 Summary
Update README with instructions for setting a minimum bid value:
The
-min-bid
flag allows setting a minimum bid value. If no bid from the builder network delivers at least this value, mev-boost will not return a bid to the beacon node, making it fall back to local block production.Example for setting a minimum bid value of 0.06 ETH:
✅ I have run these commands
make lint
make test-race
go mod tidy