Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: added instructions for -min-bid #417

Merged
merged 1 commit into from
Nov 22, 2022
Merged

README: added instructions for -min-bid #417

merged 1 commit into from
Nov 22, 2022

Conversation

metachris
Copy link
Collaborator

@metachris metachris commented Nov 19, 2022

📝 Summary

Update README with instructions for setting a minimum bid value:


The -min-bid flag allows setting a minimum bid value. If no bid from the builder network delivers at least this value, mev-boost will not return a bid to the beacon node, making it fall back to local block production.

Example for setting a minimum bid value of 0.06 ETH:

mev-boost \
    -min-bid 0.06 \
    -relay $YOUR_RELAY_CHOICE_A \
    -relay $YOUR_RELAY_CHOICE_B \
    -relay $YOUR_RELAY_CHOICE_C

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Merging #417 (cdf731d) into main (d5f7061) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   65.93%   65.93%           
=======================================
  Files           7        7           
  Lines         907      907           
=======================================
  Hits          598      598           
  Misses        274      274           
  Partials       35       35           
Flag Coverage Δ
unittests 65.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to add this to the readme! Just a few little nits.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@metachris metachris merged commit 9953a37 into main Nov 22, 2022
@metachris metachris deleted the readme-min-bid branch November 22, 2022 15:36
@metachris
Copy link
Collaborator Author

whooos, sorry the requests for changes were just below the approval notice, and the merge button was green, so i merged it.

will post a PR with the changes, thx @jtraglia

@jtraglia
Copy link
Collaborator

No worries! Thanks.

@metachris metachris mentioned this pull request Nov 22, 2022
3 tasks
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants