Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker image on tags without - only (i.e. not for -rc1, -beta) #345

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

metachris
Copy link
Collaborator

📝 Summary

Before this PR, every new tag seen by Github would create and push a flasthbots/mev-boost:latest Docker tag.

With this PR, this only happens for tags that don't include a dash, like v1.2.3.

For tags with dash - like v1.2.4-rc1 or v1.2.4-beta1` - only the Docker image for this specific version is built and pushed.


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

Codecov Report

Merging #345 (735b4cd) into main (6a61a56) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files           5        5           
  Lines         680      680           
=======================================
  Hits          557      557           
  Misses         94       94           
  Partials       29       29           
Flag Coverage Δ
unittests 81.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@metachris metachris merged commit b2c3873 into main Sep 27, 2022
@metachris metachris deleted the docker-ci-rc-latest branch September 27, 2022 14:59
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants