Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to fix this annoying flaky test #327

Merged
merged 1 commit into from
Sep 17, 2022
Merged

trying to fix this annoying flaky test #327

merged 1 commit into from
Sep 17, 2022

Conversation

metachris
Copy link
Collaborator

πŸ“ Summary

One test is randomly failing. Trying to fix this here.


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Merging #327 (85dd9ff) into main (d210027) will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   81.54%   82.44%   +0.89%     
==========================================
  Files           5        5              
  Lines         672      672              
==========================================
+ Hits          548      554       +6     
+ Misses         93       90       -3     
+ Partials       31       28       -3     
Flag Coverage Ξ”
unittests 82.44% <ΓΈ> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
server/service.go 81.23% <0.00%> (+1.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@metachris metachris merged commit 05468dc into main Sep 17, 2022
@metachris metachris deleted the fix-flaky-test branch September 17, 2022 11:02
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants