Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enhance relay with whitelist filtering capability for validator and builder selection #657

Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

feat: Enhance relay with whitelist filtering capability for validator and builder selection #657

wants to merge 69 commits into from

Conversation

ckartik
Copy link

@ckartik ckartik commented Oct 14, 2024 •
edited
Loading

📝 Summary

This PR integrates mev-commit functionality into the relay, enabling support for mev-commit registered validators and builders.
image

⛱ Motivation and Context

This enhancement provides a more structured approach to block submission, focusing on whitelist-based validation to support preconfirmation protocols like mev-commit. It constrains block submissions to vetted builders during a validator’s purposing slot if opted into whitelist filtering.

Key changes include:

  • New MevCommitClient to interact with mev-commit contracts
  • Update Housekeeper to periodically sync mev-commit validator and builder registrations
    • The housekeeper has 2 added duties:
      • Monitor all builder registrations and de-registrations on the mev-commit platform
      • Load all the validators registered in mev-commit that are responsible for proposing a block in the next two epochs
  • Modify block submission handling to check mev-commit registration status, and if a validator and builder is opted-in.
  • Add Redis caching for mev-commit registration data

📚 References

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@ckartik
wip
9365717
@ckartik
wip: implements basic filtering
8030776
@ckartik
wip: adds comments around technical decisions that need to be made.
2776c6a
@ckartik
wip: adds mevcommit relay
be89e84
@ckartik
wip: documenting some thoughts
f6703a1
@ckartik
wip: more details
b498fe3
@ckartik
feat: adds opted in column to builder table
5216a9f
@ckartik
feat: adds opted in status for validators
44adf4c
@ckartik
feat: stubs basic mevcommit client
c440444
@ckartik
feat: get's current opted in status of validators via mev-commit client
274a15e
@ckartik
feat: adds new table instead of just column
7de9955
@ckartik
feat: adds the new table migration
f95c086
@ckartik
feat: adds db entries for validators
fa672e0
@ckartik
feat: updates format of validator registration
bd03f6f
@ckartik
feat: adds a redis handlers for validator registration
54ea6de
@ckartik
feat: wip move most data to redis for validators
9f236de
@ckartik
feat: completes implementation of mevcommit client
d1d8e5f
@ckartik
feat: use the provider registry client
26d3047
@ckartik
feat: wip adds all the e2e calls to complete implementation for relay…
ed193ab 
… changes
@ckartik
chore: adds to public interface
79254ca
@ckartik
chore: make sure we're also updating the builder registrations
5967122
@ckartik
chore: removes DB entries for now
e22eb54
@ckartik
chore: adds the unit tests for the mev-commit client
1525d87
@ckartik
feat: adds more unit test coverage.
bb957ae
@ckartik
chore: fix variable naming
0400be7
@ckartik
nit: ensure we grab readlock on purposer duties map
5149183
@ckartik
chore: cleanup
6a05c1f
@ckartik
chore: configures correct os vars on startup
152c784
@ckartik
feat: allow toggling of mev-commit filtering feature
a0a7249
@ckartik
nit: fixes two small bugs and adds a unit test
79045fd
ckartik and others added 19 commits October 9, 2024 16:11
@ckartik
chore: move time start for monitoring to top level
52410bf
@ckartik
nit: reduce log level
ece5972
@ckartik
chore: removes legacy getbuilders
5314d28
@ckartik
chore: clean up code and fix anti-pattern
550bdcc
@ckartik
feat: track slashes
03b13c1
@ckartik
nit: made changes event registration checks
941ba64
@ckartik
Merge pull request #1 from primev/ckartik/add-mev-commit-support
426c229 
Adds mev commit support to flashbots relay
@ckartik
nit: remove gitignore changes
aa56c41
@ckartik
nit: remove change in database.go
6dcb0f5
@ckartik
chore: removes all db related changes
866c4ac
@ckartik
nit: remove redundant todo
f3cb4f1
@ckartik
Merge pull request #2 from primev/ckartik/final-cleanup
21c486f 
chore: final cleanup of redundant comments and code
@ckartik
chore: remove redundant validator deletion
dd5f08e
@ckartik
chore: runs gofumpt
d4d63f5
@ckartik
chore: fixes all issues identified by linter (#3)
93c336f
@ckartik
chore: simplify blocknumber retrieval
dca4cb5
@ckartik
nit: remove comment
28b6991
@ckartik
nit: add more test coverage on redis
9dfd417
@ckartik
nit: make sure filtering is on during all tests
32c96f0
@ckartik ckartik marked this pull request as ready for review October 14, 2024 16:23
ckartik and others added 9 commits October 14, 2024 17:29
@ckartik
chore: downgrade go
ae70252
@ckartik
nit: bump go-ethereum version
ac5b759
@ckartik
feat: faster filtering and more test coverage
3ea3e16
@ckartik
nit: comment cleanup
c50bce5
@ckartik
chore: replace http with ws connection
89402c7
@ckartik
nit: cleanup test
422eb7c
@ckartik
feat: adds LRU cache for mevcommit registrations
0354237
@ckartik
feat: stores validator opted in status in proposer duties map (#4)
b9dcb96 
* feat: stores validator opted in status in proposer duties map

* feat: clean up mevcommit validator redis keys

* feat: verifies correct encoding

* chore: ensures we trim prefix to adhere to contract format

* feat: also removes redundant builder cleanup
@ckartik
feat: Reduces critical path latency by caching builder info in runtim…
63b4b42 
…e memory (#5)

* feat: first checks builder cache for opt in status

* nit: clean up

* nit: fix bracket order

* chore: remove dupe not ok

* nit: adds testing

* feat: adds builder pubkey to test

* nit: remove todo as implmentation is complete
@ckartik ckartik changed the title feat: Integrate mev-commit functionality into relay feat: Enhance relay with whitelist filtering capability for validator and builder selection Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ckartik