Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if a tag does not exist, we dont want the query to crash #61

Merged
merged 4 commits into from
Jun 3, 2019
Merged

if a tag does not exist, we dont want the query to crash #61

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6680e5a
if a tag does not exist, we dont want the query to crash
tom-it May 25, 2019
355c350
incorrect solution
tom-it May 28, 2019
8995878
repaired getIdForSlug function to return int or null
tom-it May 28, 2019
eb0b760
changed where, removed isempty not needed
tom-it May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/TagRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,15 @@ public function all(User $user = null)
* @param User|null $user
* @return int
*/
public function getIdForSlug($slug, User $user = null)
public function getIdForSlug($slug, User $user = null) : ?int
{
$query = Tag::where('slug', 'like', $slug);
franzliedke marked this conversation as resolved.
Show resolved Hide resolved

return $this->scopeVisibleTo($query, $user)->pluck('id');

if ($query->get()->isEmpty()) {
return null;
}
tom-it marked this conversation as resolved.
Show resolved Hide resolved

return $this->scopeVisibleTo($query, $user)->value('id');
}

/**
Expand Down