Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag filtering to include partial matches #164

Closed
wants to merge 1 commit into from
Closed

Update tag filtering to include partial matches #164

wants to merge 1 commit into from

Conversation

rafaucau
Copy link
Contributor

@rafaucau rafaucau commented Apr 9, 2023

Changes proposed in this pull request:
This pull request updates the tag filtering functionality to include partial matches when searching for tags. The previous implementation used substring method to match the tags with the filter string, which only matched tags starting from the beginning of the tag name.

The new implementation uses the includes method to match the filter string with any part of the tag name. This means that users can now search for tags based on partial matches, making it easier to find relevant tags.

Screenshot

Tag list:
image

Before After
Before After

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9
Copy link
Member

SychO9 commented Apr 10, 2023

Thanks for the PR!

As this is a read-only repository I will be closing this, the actual development takes place at https://github.com/flarum/framework, please feel free to re-open the PR there 🙏🏼.

@SychO9 SychO9 closed this Apr 10, 2023
@rafaucau rafaucau deleted the search_anywhere branch April 10, 2023 10:55
@rafaucau rafaucau restored the search_anywhere branch April 10, 2023 10:55
@rafaucau rafaucau deleted the search_anywhere branch April 10, 2023 18:58
@rafaucau
Copy link
Contributor Author

Re-opened flarum/framework#3786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants