Fix background size after flarum/core#1496 was merged #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #1553
2 tasks
|
Would using a % instead of px work? |
|
Yeah, percentages would be nice. That would mean it won't need an update after Toby decides to redesign the page again. |
|
Pixels: Percentages: |
askvortsov1
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Fix background size after flarum/framework#1496 was merged Related to #1553 * Use percentages
askvortsov1
pushed a commit
that referenced
this pull request
May 10, 2022
* Fix background size after flarum/framework#1496 was merged Related to #1553 * Use percentages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to flarum/framework#1553
As mentioned in flarum/framework#1553, the ratio for the new sizes is 3:1. I tried both
19pxand18pxfor the width, and 19px seemed to fit better and looked more centered.Before:
After:
