Stop mentions dropdown from jumping around #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
askvortsov1
commented
Jun 30, 2020
•
askvortsov1
commented
- Cache the order in which users are returned by the API to stop the mentions list from jumping around
- Only ping the api when 2 or more characters are entered
clarkwinkelmann
approved these changes
Jul 1, 2020
|
Is that an issue you're still seeing in this PR? The PR should actually mostly fix that I believe |
|
I have not tested. But I don't think this PR changes anything to the behavior of the user list. It just changes the order of the post list and user list. That's fine, we'll revisit the other issues later. I'll need to check whether a GitHub issue exists for what I'm mentioning. |
askvortsov1
changed the title
|
@clarkwinkelmann since I pretty much completely changed up this PR, I've rerequested your review. |
tankerkiller125
approved these changes
Jul 1, 2020
clarkwinkelmann
approved these changes
Jul 1, 2020
askvortsov1
added a commit
that referenced
this pull request
Mar 11, 2022
Cache the order in which users are returned by the API to stop the mentions list from jumping around Only ping the api when 2 or more characters are entered
askvortsov1
added a commit
that referenced
this pull request
May 10, 2022
Cache the order in which users are returned by the API to stop the mentions list from jumping around Only ping the api when 2 or more characters are entered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.