Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] chore: change private to protected, allowing extensibility #4119

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

imorland
Copy link
Member

Simply change private to protected so we can extend and replace ResponseFactory when required.

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland requested a review from a team as a code owner November 19, 2024 16:45
@imorland imorland changed the title chore: change private to protected, allowing extensibility [1.x] chore: change private to protected, allowing extensibility Nov 19, 2024
@imorland imorland added this to the 1.8.9 milestone Nov 19, 2024
@imorland imorland merged commit d61c3cf into 1.x Nov 19, 2024
314 checks passed
@imorland imorland deleted the im/auth branch November 19, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant