Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make excerpt optional in sticky #4016

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

feat: make excerpt optional in sticky #4016

wants to merge 3 commits into from

Conversation

lycorisor
Copy link

@lycorisor lycorisor requested a review from a team as a code owner August 15, 2024 14:18
SychO9
SychO9 requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! some comments

extensions/sticky/extend.php Outdated Show resolved Hide resolved
extensions/sticky/js/src/admin/index.js Outdated Show resolved Hide resolved
extensions/sticky/js/src/forum/addStickyExcerpt.js Outdated Show resolved Hide resolved
extensions/sticky/locale/en.yml Outdated Show resolved Hide resolved
@lycorisor
Copy link
Author

applied your comment

@lycorisor lycorisor requested a review from SychO9 August 15, 2024 15:17
SychO9
SychO9 requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete this so that it visually works as expected.

The excerpt should not be displayed when the setting is off, the next extend of the same file changed needs to also be adapted to that.

@lycorisor
Copy link
Author

Hello, please describe your requirements in detail. I have applied your suggestions in the chore commit.

@lycorisor lycorisor requested a review from SychO9 August 16, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 Awaiting requested review from SychO9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lycorisor @SychO9