-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export all missing modules in compat #4006
Conversation
@DavideIadeluca what's the progress on this one, are you able to complete this soon-ish? |
I just did a round of testing and everything seems to be in order. The CI is failing, but it doesn't appear to be related to the changes I made. PR is ready for review from my side now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, I'll include it in the upcoming 1.8.6
release
Ps, would you mind doing the same for |
Yes, sure I can. I suggested doing it just before the first beta is released in case new components/utils are added/removed etc. and forgotten to be added in |
I am reverting this until we can resolve the js typings errors in the CI.. @DavideIadeluca can you possibly take a look at this when you can? |
Fixes #0000
Changes proposed in this pull request:
Export all missing modules with the Compat API and therefore improve the extensibility of the framework.
Reviewers should focus on:
We need to make sure that those exports are adopted in the 2.x equivalent (
forum.ts
). I suggest that the export registry upgrade step is used just before the first 2.0 beta is released.Screenshot
QA
fireDebugWarning
)fireDeprecationWarning
)Necessity
Confirmed
composer test
).Required changes: