Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bbcode): localize quote wrote string #3809

Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix(bbcode): localize quote wrote string #3809

merged 1 commit into from
Apr 27, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 27, 2023

Fixes #3807

Changes proposed in this pull request:

  • Allows localizing the wrote bit of the quote bbcode.
  • This PR takes into consideration previous attempts. The translated string is not cached with the renderer cache. It is resolved on new renders.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner April 27, 2023 18:14
davwheat
davwheat requested changes Apr 27, 2023
View reviewed changes
extensions/bbcode/extend.php
$config->BBCodes->addFromRepository('EMAIL');
$config->BBCodes->addFromRepository('CODE');
$config->BBCodes->addFromRepository('QUOTE', 'default', [
'authorStr' => '<xsl:value-of select="@author"/> <xsl:value-of select="$L_WROTE"/>'
Copy link
Member

@davwheat davwheat Apr 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the author string be part of the translation instead? Some languages might need "wrote author" instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe that that's possible to do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate... Either way, a locale ext could override this in their extend.php anyway, so

@imorland imorland added this to the 1.8 milestone Apr 27, 2023
@imorland imorland merged commit 4784307 into main Apr 27, 2023
@imorland imorland deleted the sm/3807-bbcode-wrote branch April 27, 2023 19:26
@github-actions github-actions bot mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
type/extensibility
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

Hardcoded "wrote" in flarum/bbcode
3 participants
@SychO9 @davwheat @imorland