Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop usage of jquery in install and update interfaces #3797

Merged
merged 3 commits into from
Apr 16, 2023
Merged

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 16, 2023

Fixes #3457

Changes proposed in this pull request:

  • Just converts the JS code to vanilla JS.
  • Tesed locally.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner April 16, 2023 12:53
framework/core/views/install/install.php Outdated Show resolved Hide resolved
framework/core/views/install/install.php Outdated Show resolved Hide resolved
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9 SychO9 requested a review from askvortsov1 April 16, 2023 19:01
.catch(error => {
console.error('Error:', error);
});
window.onload = function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/a/37401912 might be a better fit, actually

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me just switch back to jQuery 🤣

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaaaaaaa noooooo!!!!!!!

Signed-off-by: Sami Mazouz <[email protected]>
@SychO9 SychO9 merged commit 4901c58 into main Apr 16, 2023
@SychO9 SychO9 deleted the sm/3457 branch April 16, 2023 20:12
@matteocontrini
Copy link
Contributor

A bit late here, but I think fetch Promise rejections should be handled too. Otherwise network errors are ignored (they weren't, in the previous jQuery implementation).

@github-actions github-actions bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate update and install pages away from legacy external jQuery
3 participants