-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop usage of jquery in install
and update
interfaces
#3797
Conversation
Signed-off-by: Sami Mazouz <[email protected]>
Signed-off-by: Sami Mazouz <[email protected]>
.catch(error => { | ||
console.error('Error:', error); | ||
}); | ||
window.onload = function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackoverflow.com/a/37401912 might be a better fit, actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me just switch back to jQuery 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaaaaaaa noooooo!!!!!!!
Signed-off-by: Sami Mazouz <[email protected]>
A bit late here, but I think fetch Promise rejections should be handled too. Otherwise network errors are ignored (they weren't, in the previous jQuery implementation). |
Fixes #3457
Changes proposed in this pull request:
Necessity
Confirmed
composer test
).Required changes: