Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(regression): cannot delete users #3746

Merged
merged 2 commits into from
Feb 24, 2023
Merged

fix(regression): cannot delete users #3746

merged 2 commits into from
Feb 24, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Feb 24, 2023 •
edited
Loading

Fixes #3745

Changes proposed in this pull request:

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner February 24, 2023 17:08
@SychO9 SychO9 merged commit fa30f4f into main Feb 24, 2023
@SychO9 SychO9 deleted the sm/delete-user branch February 24, 2023 17:22
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot delete user accounts
2 participants
@SychO9 @StyleCIBot