fix: add viewPrivate visibility scope #3596
Draft
+88
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Fixes #3594 **
Changes proposed in this pull request:
Allow discussions to be conditionally visible via
viewPrivate
scopers, when the user does not have theeditPosts
permission.I feel that improving the tests for
flarum/approval
is also required, unfortunately I cannot run them locally atm, so perhaps someone would be kind enough to add?Reviewers should focus on:
I've tested this change with 3rd party extensions, such as
fof/byobu
, which also makes use ofviewPrivate
, and there does not appear to be any side effects, but perhaps there's something I've not considered by opening this up a little?Screenshot
Necessity
Confirmed
composer test
).Required changes: