Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: maintenance pre-1.2 release #3213

Merged
merged 4 commits into from
Dec 27, 2021
Merged

chore: maintenance pre-1.2 release #3213

merged 4 commits into from
Dec 27, 2021

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

Performs minor repo maintenance in the lead up to the v1.2 release.

  • Bumps JS dependencies
  • Bumps Yarn version

Reviewers should focus on:

Missing anything?

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.2 milestone Dec 20, 2021
@davwheat davwheat self-assigned this Dec 20, 2021
@davwheat
Copy link
Member Author

Note: failing task is extend.ts which gets fixed as part of #3214

askvortsov1
askvortsov1 approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming rebasing once #3214 is fixed makes CI pass

@dsevillamartin
Copy link
Member

Do we want to perhaps add to this PR or another one a line to .gitattributes to hide yarn lock diff by default? Like package-lock.json?

@davwheat
Copy link
Member Author

Yeah that's a good idea

@davwheat davwheat merged commit d65deec into master Dec 27, 2021
@davwheat davwheat deleted the dw/1.2-maintenance branch December 27, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@SychO9 SychO9 SychO9 approved these changes

Assignees

@davwheat davwheat

Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@davwheat @dsevillamartin @SychO9 @askvortsov1