Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clicking three dots on post opens all dropdowns in .Post-actions #3185

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Dec 1, 2021

Changes proposed in this pull request:

  • When clicking three dots under a Post, only add the .open class to .Post-controls, not the entire .Post-actions container

Reviewers should focus on:

N/A

Screenshot (before)

bgHalgYy.1.mp4

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@davwheat davwheat added this to the 1.2 milestone Dec 1, 2021
@davwheat davwheat self-assigned this Dec 1, 2021
@SychO9 SychO9 merged commit c219699 into master Dec 6, 2021
@SychO9 SychO9 deleted the dw/fix-double-dropdown-open branch December 6, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants