Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Close' & 'Back' aria-label attributes to buttons. #3161

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Add 'Close' & 'Back' aria-label attributes to buttons. #3161

merged 6 commits into from
Nov 11, 2021

Commits on Nov 11, 2021

  1. Add 'Close' aria-label attributes to close buttons.

    @grimmdude
    grimmdude committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    12b1451 View commit details
    Browse the repository at this point in the history

  2. Remove extra line.

    @grimmdude
    grimmdude committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    fccce07 View commit details
    Browse the repository at this point in the history

  3. Fix app path and add more aria-labels

    @grimmdude
    grimmdude committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    6dc8a9a View commit details
    Browse the repository at this point in the history

  4. Use 'Back' for back button...

    @grimmdude
    grimmdude committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    a6174ff View commit details
    Browse the repository at this point in the history

  5. Use more descriptive label for welcome hero. Use specific modal key f… 

    …or modal close label.
    @grimmdude
    grimmdude committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    f81eebd View commit details
    Browse the repository at this point in the history

  6. Replace title with aria-label in nav back.

    @grimmdude
    grimmdude committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    f161c96 View commit details
    Browse the repository at this point in the history