feat: allow use of any tag in listItems
helper
#3147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This PR allows the use of any tag with the
listItems
helper function. This is useful to easily map an ItemList into separate DOM nodes outside of a<ul>
element, without the need of code duplication.Not everything needs to be a list. In fact, using
<ul>
and<li>
too much is a common issue across the web, and is the reason why WebKit (Safari on macOS and iOS) actually remove all semantics from list tags when theirlist-style
is set tonone
. (Source)This change could help to prevent such "list-itis" within Flarum and its extensions.
Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test
).Required changes: