Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textarea setting type & refactor some code to clean up #3141

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

dsevillamartin
Copy link
Member

Refs #2809

Changes proposed in this pull request:

  • Refactor some code for buildSettingComponent to reduce duplication
  • Add textarea setting type

Reviewers should focus on:

  • Code look good?
  • Didn't add text editor because that was more complicated

Screenshot

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • [] If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@dsevillamartin dsevillamartin merged commit 1e595e7 into master Oct 30, 2021
@dsevillamartin dsevillamartin deleted the ds/2809-add-textarea-setting-type branch October 30, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants