Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass IP address to API Client pipeline #3124

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

askvortsov1
Copy link
Member

@askvortsov1 askvortsov1 commented Oct 26, 2021

Fixes #2985

Changes proposed in this pull request:
Uses parent request's IP address for API client request.
The ProcessIp middleware won't run twice as that's in the global middleware stack, which the API client doesn't go through.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

The `ProcessIp` middleware won't run twice as that's in the global middleware stack, which the API client doesn't go through.
@askvortsov1 askvortsov1 merged commit f7a78d8 into master Oct 26, 2021
@askvortsov1 askvortsov1 deleted the as/pass-ip-to-api-client branch October 26, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipAddress request attribute not available when passing through API Client
3 participants