Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against php 8.1 #3102

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Test against php 8.1 #3102

merged 1 commit into from
Oct 13, 2021

Conversation

sergiy-petrov
Copy link

No description provided.

@davwheat
Copy link
Member

Not a comment about the PR content itself, but I do wonder why we don't automate tests against MySQL 8, as we do support it.

askvortsov1
askvortsov1 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should. Moreover, I would like to eventually have a flarum-cli audit command that we could couple with a GitHub action to help us sync these infra changes across all repositories. For now though, thank you for the contribution!

@askvortsov1 askvortsov1 merged commit 919c543 into flarum:master Oct 13, 2021
@askvortsov1 askvortsov1 added this to the 1.2 milestone Oct 13, 2021
@matteocontrini
Copy link
Contributor

Not a comment about the PR content itself, but I do wonder why we don't automate tests against MySQL 8, as we do support it.

We probably should.

Is there an issue to track this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sergiy-petrov @davwheat @matteocontrini @askvortsov1